Add ServiceConnect image to clean-up exclusion list #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinyic
force-pushed
the
sc-image-cleanup-exclusion
branch
3 times, most recently
from
209842f to
d4e2174
Compare
yinyic
force-pushed
the
sc-image-cleanup-exclusion
branch
from
d4e2174 to
58f4917
Compare
yinyic
commented
Dec 15, 2022
|
|
||
| ts := httptest.NewUnstartedServer(r) | ||
| ts := httptest.NewUnstartedServer(r) | ||
| defer ts.Close() |
There was a problem hiding this comment.
I received this error when running unit test listen unix /tmp/appnet_admin.sock: bind: address already in use
Moving ts.Close() up in a defer statement should help us clean up always.
mythri-garaga
approved these changes
Dec 15, 2022
ubhattacharjya
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ECS Agent periodically cleans up cached docker container images that are not being referenced. There are a few images on the exception list including pause container. We should add Service Connect Agent (aka AppNet Agent) image to this list as well because all SC tasks require cached SC Agent image.
#3520
Implementation details
Added a new function
AddImageToCleanUpExclusionListto ImageManager, and when ECS Agent bootstrap, weStep 1 has to happen first since the image name might be different depending on the AppNet Agent version installed.
Testing
New tests cover the changes: no
Logs with update ECS Agent:
Description for the changelog
Add ServiceConnect image to clean-up exclusion list
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.